]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
blur-effect: Only apply paint opacity once when blurring actor
authorJonas Dreßler <verdre@v0yd.nl>
Fri, 7 Feb 2020 09:23:20 +0000 (10:23 +0100)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Wed, 12 Feb 2020 14:02:28 +0000 (14:02 +0000)
We don't want to apply the opacity multiple times, because this would
also multiply the opacity we're applying.

https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/991

src/shell-blur-effect.c

index f7b391dad427930a45bce1cff634ff7b336f1933..dc77714f957910ae6b0091f2a8df3755b6039a04 100644 (file)
@@ -588,12 +588,6 @@ apply_blur (ShellBlurEffect     *self,
   hblur = &self->blur[HORIZONTAL];
 
   /* Copy the actor contents into the vblur framebuffer */
-  cogl_pipeline_set_color4ub (from->pipeline,
-                              paint_opacity,
-                              paint_opacity,
-                              paint_opacity,
-                              paint_opacity);
-
   clear_framebuffer (vblur->data.framebuffer);
   cogl_framebuffer_draw_rectangle (vblur->data.framebuffer,
                                    from->pipeline,
@@ -609,11 +603,6 @@ apply_blur (ShellBlurEffect     *self,
    * blurred image.
    */
   update_blur_uniforms (self, vblur);
-  cogl_pipeline_set_color4ub (vblur->data.pipeline,
-                              paint_opacity,
-                              paint_opacity,
-                              paint_opacity,
-                              paint_opacity);
 
   clear_framebuffer (hblur->data.framebuffer);
   cogl_framebuffer_draw_rectangle (hblur->data.framebuffer,